netdev - Re: [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 09 Apr 2020 11:50:01 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Pradeep Kumar Chitrapu <pradeepc@...eaurora.org>,
        netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        ath11k@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling

Arnd Bergmann <arnd@...db.de> writes:

> The empty stub version of this function causes a compile-time
> warning:
>
> In file included from drivers/net/wireless/ath/ath11k/core.h:23,
>                  from drivers/net/wireless/ath/ath11k/dp_rx.h:8,
>                  from drivers/net/wireless/ath/ath11k/ce.c:6:
> drivers/net/wireless/ath/ath11k/thermal.h: In function 'ath11k_thermal_set_throttling':
> drivers/net/wireless/ath/ath11k/thermal.h:45:1: error: no return statement in function returning non-void [-Werror=return-type]
>
> Just return success here.
>
> Fixes: a41d10348b01 ("ath11k: add thermal sensor device support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/wireless/ath/ath11k/thermal.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h
> index 459b8d49c184..f1395a14748c 100644
> --- a/drivers/net/wireless/ath/ath11k/thermal.h
> +++ b/drivers/net/wireless/ath/ath11k/thermal.h
> @@ -42,6 +42,7 @@ static inline void ath11k_thermal_unregister(struct ath11k *ar)
>  
>  static inline int ath11k_thermal_set_throttling(struct ath11k *ar, u32 throttle_state)
>  {
> +	return 0;
>  }

Already fixed by this commit:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=c9be1a642a7b9ec021e3f32e084dc781b3e5216d

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches