netdev - Re: [PATCH v3] net: qrtr: send msgs from local of same id as broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 09 Apr 2020 10:09:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wenhu.wang@...o.com
Cc:     kuba@...nel.org, bjorn.andersson@...aro.org, wgong@...eaurora.org,
        allison@...utok.net, willemb@...gle.com, arnd@...db.de,
        johannes.berg@...el.com, cjhuang@...eaurora.org,
        tglx@...utronix.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...o.com
Subject: Re: [PATCH v3] net: qrtr: send msgs from local of same id as
 broadcast

From: Wang Wenhu <wenhu.wang@...o.com>
Date: Wed,  8 Apr 2020 19:53:53 -0700

> If the local node id(qrtr_local_nid) is not modified after its
> initialization, it equals to the broadcast node id(QRTR_NODE_BCAST).
> So the messages from local node should not be taken as broadcast
> and keep the process going to send them out anyway.
> 
> The definitions are as follow:
> static unsigned int qrtr_local_nid = NUMA_NO_NODE;
> #define QRTR_NODE_BCAST	0xffffffffu
> 
> Fixes: commit fdf5fd397566 ("net: qrtr: Broadcast messages only from control port")
> Signed-off-by: Wang Wenhu <wenhu.wang@...o.com>

Please do not put the word "commit" in your Fixes: tag in the future,
it does not belong there.

Applied and queued up for -stable, thanks.