netdev - Re: [PATCH net] net/ipv6: allow token to be set when accept

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200410011704.GH2159@dhcp-12-139.nay.redhat.com>
Date:   Fri, 10 Apr 2020 09:17:05 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, daniel@...earbox.net,
        yoshfuji@...ux-ipv6.org, thaller@...hat.com
Subject: Re: [PATCH net] net/ipv6: allow token to be set when accept_ra
 disabled

On Thu, Apr 09, 2020 at 10:13:55AM -0700, David Miller wrote:
> From: Hangbin Liu <liuhangbin@...il.com>
> Date: Thu,  9 Apr 2020 14:56:04 +0800
> 
> > The token setting should not depend on whether accept_ra is enabled or
> > disabled. The user could set the token at any time. Enable or disable
> > accept_ra only affects when the token address take effective.
> > 
> > On the other hand, we didn't remove the token setting when disable
> > accept_ra. So let's just remove the accept_ra checking when user want
> > to set token address.
> > 
> > Fixes: f53adae4eae5 ("net: ipv6: add tokenized interface identifier support")
> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> 
> It is dangerous to change this, because now people can write bootup
> and configuration scripts that will work with newer kernels yet fail
> unexpectedly in older kernels.

Hmm, this makes sense to me. Thanks for the explanation.

Regards
Hangbin

> 
> I think requiring that RA be enabled in order to set the token is
> an absolutely reasonable requirement.