lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Apr 2020 14:13:20 -0300 From: Jason Gunthorpe <jgg@...pe.ca> To: Saeed Mahameed <saeedm@...lanox.com> Cc: "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>, "arnd@...db.de" <arnd@...db.de>, "narmstrong@...libre.com" <narmstrong@...libre.com>, "masahiroy@...nel.org" <masahiroy@...nel.org>, "leon@...nel.org" <leon@...nel.org>, "Laurent.pinchart@...asonboard.com" <Laurent.pinchart@...asonboard.com>, "kieran.bingham+renesas@...asonboard.com" <kieran.bingham+renesas@...asonboard.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "nico@...xnic.net" <nico@...xnic.net>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "davem@...emloft.net" <davem@...emloft.net>, "a.hajda@...sung.com" <a.hajda@...sung.com>, "jonas@...boo.se" <jonas@...boo.se>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "airlied@...ux.ie" <airlied@...ux.ie>, "jernej.skrabec@...l.net" <jernej.skrabec@...l.net> Subject: Re: [RFC 0/6] Regressions for "imply" behavior change On Fri, Apr 10, 2020 at 02:40:42AM +0000, Saeed Mahameed wrote: > This assumes that the module using FOO has its own flag representing > FOO which is not always the case. > > for example in mlx5 we use VXLAN config flag directly to compile VXLAN > related files: > > mlx5/core/Makefile: > > obj-$(CONFIG_MLX5_CORE) += mlx5_core.o > > mlx5_core-y := mlx5_core.o > mlx5_core-$(VXLAN) += mlx5_vxlan.o > > and in mlx5_main.o we do: Does this work if VXLAN = m ? > if (IS_ENABLED(VXLAN)) > mlx5_vxlan_init() > > after the change in imply semantics: > our options are: > > 1) use IS_REACHABLE(VXLAN) instead of IS_ENABLED(VXLAN) > > 2) have MLX5_VXLAN in mlx5 Kconfig and use IS_ENABLED(MLX5_VXLAN) > config MLX5_VXLAN > depends on VXLAN || !VXLAN > bool Does this trick work when vxlan is a bool not a tristate? Why not just put the VXLAN || !VXLAN directly on MLX5_CORE? Jason
Powered by blists - more mailing lists