netdev - RE: [PATCH] net: phy: micrel: use genphy_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Apr 2020 18:41:24 +0000
From:   <Yuiko.Oshino@...rochip.com>
To:     <kuba@...nel.org>, <atsushi.nemoto@...d.co.jp>
CC:     <netdev@...r.kernel.org>, <tomonori.sakita@...d.co.jp>
Subject: RE: [PATCH] net: phy: micrel: use genphy_read_status for KSZ9131

>From: Jakub Kicinski <kuba@...nel.org>
>Sent: Friday, April 10, 2020 2:00 PM
>To: Atsushi Nemoto <atsushi.nemoto@...d.co.jp>
>Cc: netdev@...r.kernel.org; Yuiko Oshino - C18177
><Yuiko.Oshino@...rochip.com>; tomonori.sakita@...d.co.jp
>Subject: Re: [PATCH] net: phy: micrel: use genphy_read_status for KSZ9131
>
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>content is safe
>
>On Fri, 10 Apr 2020 12:16:16 +0900 (JST) Atsushi Nemoto wrote:
>> KSZ9131 will not work with some switches due to workaround for KSZ9031
>> introduced in commit d2fd719bcb0e83cb39cfee22ee800f98a56eceb3
>> ("net/phy: micrel: Add workaround for bad autoneg").
>> Use genphy_read_status instead of dedicated ksz9031_read_status.
>
>That commit older than support for KSZ9131 itself, right?
>If so we should blame this one:
>
>Fixes: bff5b4b37372 ("net: phy: micrel: add Microchip KSZ9131 initial driver")
>
>Yuiko, does this change look good to you?

Let me check with my team and get back to you.
- Yuiko
>
>> Signed-off-by: Atsushi Nemoto <atsushi.nemoto@...d.co.jp>
>> ---
>>  drivers/net/phy/micrel.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index
>> 05d20343b816..3a4d83fa52dc 100644
>> --- a/drivers/net/phy/micrel.c
>> +++ b/drivers/net/phy/micrel.c
>> @@ -1204,7 +1204,7 @@ static struct phy_driver ksphy_driver[] = {
>>       .driver_data    = &ksz9021_type,
>>       .probe          = kszphy_probe,
>>       .config_init    = ksz9131_config_init,
>> -     .read_status    = ksz9031_read_status,
>> +     .read_status    = genphy_read_status,
>>       .ack_interrupt  = kszphy_ack_interrupt,
>>       .config_intr    = kszphy_config_intr,
>>       .get_sset_count = kszphy_get_sset_count,