lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 11 Apr 2020 19:13:14 -0400 From: Sasha Levin <sashal@...nel.org> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org Cc: Qiujun Huang <hqjagain@...il.com>, syzbot+4496e82090657320efc6@...kaller.appspotmail.com, Hillf Danton <hdanton@...a.com>, Marcel Holtmann <marcel@...tmann.org>, Sasha Levin <sashal@...nel.org>, linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org Subject: [PATCH AUTOSEL 4.14 25/37] Bluetooth: RFCOMM: fix ODEBUG bug in rfcomm_dev_ioctl From: Qiujun Huang <hqjagain@...il.com> [ Upstream commit 71811cac8532b2387b3414f7cd8fe9e497482864 ] Needn't call 'rfcomm_dlc_put' here, because 'rfcomm_dlc_exists' didn't increase dlc->refcnt. Reported-by: syzbot+4496e82090657320efc6@...kaller.appspotmail.com Signed-off-by: Qiujun Huang <hqjagain@...il.com> Suggested-by: Hillf Danton <hdanton@...a.com> Signed-off-by: Marcel Holtmann <marcel@...tmann.org> Signed-off-by: Sasha Levin <sashal@...nel.org> --- net/bluetooth/rfcomm/tty.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c index 5f3074cb6b4db..b6f26ec9e90cd 100644 --- a/net/bluetooth/rfcomm/tty.c +++ b/net/bluetooth/rfcomm/tty.c @@ -413,10 +413,8 @@ static int __rfcomm_create_dev(struct sock *sk, void __user *arg) dlc = rfcomm_dlc_exists(&req.src, &req.dst, req.channel); if (IS_ERR(dlc)) return PTR_ERR(dlc); - else if (dlc) { - rfcomm_dlc_put(dlc); + if (dlc) return -EBUSY; - } dlc = rfcomm_dlc_alloc(GFP_KERNEL); if (!dlc) return -ENOMEM; -- 2.20.1
Powered by blists - more mailing lists