netdev - Re: NET: r8169 driver fix/enchansments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e637dd4-73af-5106-90f7-1d261df06fd2@gmail.com>
Date:   Mon, 13 Apr 2020 01:18:08 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Lauri Jakku <lauri.jakku@...inet.fi>
Cc:     netdev@...r.kernel.org
Subject: Re: NET: r8169 driver fix/enchansments

On 12.04.2020 14:55, Lauri Jakku wrote:
> Hi,
> 
> 
> I've made r8169 driver improvements & fixes, please see attachments.
> 
> 
> --Lauri J.
> 
> 
This mail doesn't meet a single formal criteria for a patch. I suggest
you start here:
https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt

At first it would be helpful to know what you're trying to fix:
Which issue on which kernel version?

"Added soft depency from realtec phy to libphy"
That's completely redundant as the Realtek PHY driver has a hard
dependency on phylib.

"u32 phydev_match = !0;"
That's weird. Do you mean ~0 here?

Then you mix completely different things in one patch.

Best first learn about how to submit a formally correct patch series,
and to whom it should be submitted. Once you submit such a RFC series,
we have a basis for a discussion.