netdev - Re: [PATCH] net: UDP repair mode for retrieving the send queue of corked UDP socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200413.133331.704932428417772141.davem@davemloft.net>
Date:   Mon, 13 Apr 2020 13:33:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lesedorucalin01@...il.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: UDP repair mode for retrieving the send queue of
 corked UDP socket

From: Leşe Doru Călin <lesedorucalin01@...il.com>
Date: Mon, 13 Apr 2020 23:09:27 +0300

> On Sun, Apr 12, 2020 at 08:56:11PM -0700, David Miller wrote:
>> From: Lese Doru Calin <lesedorucalin01@...il.com>
>> Date: Wed, 8 Apr 2020 23:59:54 +0300
>> 
>> > +static int udp_peek_sndq(struct sock *sk, struct msghdr *msg, int off, int len)
>> > +{
>> > +	struct sk_buff *skb;
>> > +	int copied = 0, err = 0, copy;
>> 
>> Please use reverse christmas tree (longest to shortest) ordering for
>> local variables.
>> 
>> > +static int udp6_peek_sndq(struct sock *sk, struct msghdr *msg, int off, int len)
>> > +{
>> > +	struct sk_buff *skb;
>> > +	int copied = 0, err = 0, copy;
>> 
>> Likewise.
>> 
>> Thank you.
> 
> I changed it accordingly. I hope it is ok.

You have to make a fresh patch posting when you fix feedback given
to you, and add appropriate version specifications to your Subject
line such as "[PATCH v2]" etc.