netdev - Re: [PATCH iproute2-next v2] ip: link_gre: Do not send ERSPAN attributes to GRE tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200413140500.3a6d4bda@hermes.lan>
Date:   Mon, 13 Apr 2020 14:05:00 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Petr Machata <petrm@...lanox.com>
Cc:     netdev@...r.kernel.org, Xin Long <lucien.xin@...il.com>,
        William Tu <u9012063@...il.com>
Subject: Re: [PATCH iproute2-next v2] ip: link_gre: Do not send ERSPAN
 attributes to GRE tunnels

On Sat,  4 Apr 2020 01:55:34 +0300
Petr Machata <petrm@...lanox.com> wrote:

> In the commit referenced below, ip link started sending ERSPAN-specific
> attributes even for GRE and gretap tunnels. Fix by more carefully
> distinguishing between the GRE/tap and ERSPAN modes. Do not show
> ERSPAN-related help in GRE/tap mode, likewise do not accept ERSPAN
> arguments, or send ERSPAN attributes.
> 
> Fixes: 83c543af872e ("erspan: set erspan_ver to 1 by default")
> Signed-off-by: Petr Machata <petrm@...lanox.com>
> Acked-by: William Tu <u9012063@...il.com>

Applied, thanks for resending