netdev - Re: [PATCH] net: UDP repair mode for retrieving the send queue of corked UDP socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200412.205611.844961656085784911.davem@davemloft.net>
Date:   Sun, 12 Apr 2020 20:56:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lesedorucalin01@...il.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: UDP repair mode for retrieving the send queue of
 corked UDP socket

From: Leşe Doru Călin <lesedorucalin01@...il.com>
Date: Wed, 8 Apr 2020 23:59:54 +0300

> +static int udp_peek_sndq(struct sock *sk, struct msghdr *msg, int off, int len)
> +{
> +	struct sk_buff *skb;
> +	int copied = 0, err = 0, copy;

Please use reverse christmas tree (longest to shortest) ordering for
local variables.

> +static int udp6_peek_sndq(struct sock *sk, struct msghdr *msg, int off, int len)
> +{
> +	struct sk_buff *skb;
> +	int copied = 0, err = 0, copy;

Likewise.

Thank you.