lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 13 Apr 2020 11:29:13 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Or Gerlitz <gerlitz.or@...il.com>
Cc:     Roi Dayan <roid@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Vlad Buslov <vladbu@...lanox.com>,
        Oz Shlomo <ozsh@...lanox.com>,
        Paul Blakey <paulb@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Leon Romanovsky <leonro@...lanox.com>
Subject: Re: [PATCH net] net/mlx5e: limit log messages due to (ovs) probing
 to _once

On Mon, Apr 13, 2020 at 09:35:54AM +0300, Or Gerlitz wrote:
> On Sun, Apr 12, 2020 at 11:15 AM Roi Dayan <roid@...lanox.com> wrote:
> 
> [..]
> 
> > in some places we already only use extack without netdev_warn.
> > so currently in favor in removing the other logs if extack error exists to
> > avoid flooding the log
> 
> +1 for using the modern messaging way (extack)
> +1 for driver diet by avoiding double messaging systems

Nice, okay. Do you prefer to do it yourselves? Otherwise I'll just
remove the _warn messages I changed in the initial patch.

Powered by blists - more mailing lists