[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200414160041.GG31763@zn.tnic>
Date: Tue, 14 Apr 2020 18:00:41 +0200
From: Borislav Petkov <bp@...e.de>
To: Leon Romanovsky <leon@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Leon Romanovsky <leonro@...lanox.com>,
Andy Gospodarek <andy@...yhouse.net>,
Ion Badulescu <ionut@...ula.org>,
Jay Vosburgh <j.vosburgh@...il.com>, linux-pm@...r.kernel.org,
netdev@...r.kernel.org, Pensando Drivers <drivers@...sando.io>,
Sebastian Reichel <sre@...nel.org>,
Shannon Nelson <snelson@...sando.io>,
Veaceslav Falico <vfalico@...il.com>
Subject: Re: [PATCH net-next 1/4] drivers: Remove inclusion of vermagic header
On Tue, Apr 14, 2020 at 06:57:29PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...lanox.com>
>
> Get rid of linux/vermagic.h includes, so that MODULE_ARCH_VERMAGIC from
> the arch header arch/x86/include/asm/module.h won't be redefined.
>
> In file included from ./include/linux/module.h:30,
> from drivers/net/ethernet/3com/3c515.c:56:
> ./arch/x86/include/asm/module.h:73: warning: "MODULE_ARCH_VERMAGIC"
> redefined
> 73 | # define MODULE_ARCH_VERMAGIC MODULE_PROC_FAMILY
> |
> In file included from drivers/net/ethernet/3com/3c515.c:25:
> ./include/linux/vermagic.h:28: note: this is the location of the
> previous definition
> 28 | #define MODULE_ARCH_VERMAGIC ""
> |
>
> Fixes: 6bba2e89a88c ("net/3com: Delete driver and module versions from 3com drivers")
> Signed-off-by: Borislav Petkov <bp@...e.de>
Just my SOB like that doesn't mean anything. You should add
Co-developed-by: me
Signed-off-by: me
if you want to state that we both worked on this fix.
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
Powered by blists - more mailing lists