netdev - RE: [EXT] Re: [PATCH v3 1/7] qedf: Keep track of num of pending flogi.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR18MB25278CD165DE5510B37846A9D2DA0@MN2PR18MB2527.namprd18.prod.outlook.com>
Date:   Tue, 14 Apr 2020 04:13:47 +0000
From:   Saurav Kashyap <skashyap@...vell.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        Javed Hasan <jhasan@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v3 1/7] qedf: Keep track of num of pending
 flogi.

Hi Martin,

> -----Original Message-----
> From: Martin K. Petersen <martin.petersen@...cle.com>
> Sent: Tuesday, April 14, 2020 6:50 AM
> To: Saurav Kashyap <skashyap@...vell.com>
> Cc: martin.petersen@...cle.com; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@...vell.com>; linux-scsi@...r.kernel.org; Javed Hasan
> <jhasan@...vell.com>; netdev@...r.kernel.org
> Subject: [EXT] Re: [PATCH v3 1/7] qedf: Keep track of num of pending flogi.
> 
> External Email
> 
> ----------------------------------------------------------------------
> 
> Saurav,
> 
> Please, no "." at the end of Subject: lines.
> 
> > - Problem: Port not coming up after bringing down the port
> >   for longer duration.
> > - Bring down the port from the switch
> > - wait for fipvlan to exhaust, driver will use
> >   default vlan (1002) and call fcoe_ctlr_link_up
> > - libfc/fcoe will start sending FLOGI
> > - bring back the port and switch discard FLOGI
> >   because vlan is different.
> > - keep track of pending flogi and if it increases
> >   certain number then do ctx reset and it will do
> >   fipvlan again.
> 
> That doesn't look like a proper commit message.
> 
> How about something like:
> 
>     If a port is brought down for an extended period of time, the
>     fipvlan counter gets exhausted and the driver will fall back to
>     default VLAN 1002 and call fcoe_ctlr_link_up to log in. However, the
>     switch will discard the FLOGI attempt because the VLAN is now
>     different.
> 
>     Keep track of the number of FLOGI attempts and if a threshold of
>     QEDF_FLOGI_RETRY_CNT is exceeded, perform a context soft reset.

<SK> Looks good.

Thanks,
~Saurav
> 
> --
> Martin K. Petersen	Oracle Linux Engineering