lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 14 Apr 2020 21:45:12 +0200
From:   Daniel Borkmann <>
To:     Toke Høiland-Jørgensen <>,
        David Ahern <>,
Cc:, David Ahern <>
Subject: Re: [PATCH bpf] xdp: Reset prog in dev_change_xdp_fd when fd is

On 4/14/20 9:17 AM, Toke Høiland-Jørgensen wrote:
> David Ahern <> writes:
>> From: David Ahern <>
>> The commit mentioned in the Fixes tag reuses the local prog variable
>> when looking up an expected_fd. The variable is not reset when fd < 0
>> causing a detach with the expected_fd set to actually call
>> dev_xdp_install for the existing program. The end result is that the
>> detach does not happen.
>> Fixes: 92234c8f15c8 ("xdp: Support specifying expected existing program when attaching XDP")
>> Signed-off-by: David Ahern <>
>> Cc: Toke Høiland-Jørgensen <>
> Ugh, my bad (obviously!). Thanks for the fix! I'll send an update to the
> selftest to catch errors like this...


> Reviewed-by: Toke Høiland-Jørgensen <>

Applied, thanks!

Powered by blists - more mailing lists