netdev - Re: [PATCH bpf] xdp: Reset prog in dev_change_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b49e845e-8841-f906-31fa-08871a4f4159@iogearbox.net>
Date:   Tue, 14 Apr 2020 21:45:12 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Toke Høiland-Jørgensen <toke@...hat.com>,
        David Ahern <dsahern@...nel.org>, ast@...nel.org
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH bpf] xdp: Reset prog in dev_change_xdp_fd when fd is
 negative

On 4/14/20 9:17 AM, Toke Høiland-Jørgensen wrote:
> David Ahern <dsahern@...nel.org> writes:
> 
>> From: David Ahern <dsahern@...il.com>
>>
>> The commit mentioned in the Fixes tag reuses the local prog variable
>> when looking up an expected_fd. The variable is not reset when fd < 0
>> causing a detach with the expected_fd set to actually call
>> dev_xdp_install for the existing program. The end result is that the
>> detach does not happen.
>>
>> Fixes: 92234c8f15c8 ("xdp: Support specifying expected existing program when attaching XDP")
>> Signed-off-by: David Ahern <dsahern@...il.com>
>> Cc: Toke Høiland-Jørgensen <toke@...hat.com>
> 
> Ugh, my bad (obviously!). Thanks for the fix! I'll send an update to the
> selftest to catch errors like this...

+1

> Reviewed-by: Toke Høiland-Jørgensen <toke@...hat.com>

Applied, thanks!