netdev - Re: [PATCH v2 1/3] net: phy: mdio: add IPQ40xx MDIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Apr 2020 14:17:22 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Robert Marko <robert.marko@...tura.hr>, andrew@...n.ch,
        hkallweit1@...il.com, linux@...linux.org.uk,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        agross@...nel.org, bjorn.andersson@...aro.org, robh+dt@...nel.org,
        mark.rutland@....com, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org
Cc:     Christian Lamparter <chunkeey@...il.com>,
        Luka Perkov <luka.perkov@...tura.hr>
Subject: Re: [PATCH v2 1/3] net: phy: mdio: add IPQ40xx MDIO driver



On 4/14/2020 11:10 AM, Robert Marko wrote:
> This patch adds the driver for the MDIO interface
> inside of Qualcomm IPQ40xx series SoC-s.
> 
> Signed-off-by: Christian Lamparter <chunkeey@...il.com>
> Signed-off-by: Robert Marko <robert.marko@...tura.hr>
> Cc: Luka Perkov <luka.perkov@...tura.hr>
> ---
> Changes from v1 to v2:
> * Remove magic default value
> * Remove lockdep_assert_held
> * Add C45 check
> * Simplify the driver
> * Drop device and mii_bus structs from private struct
> * Use devm_mdiobus_alloc_size()
> 
>  drivers/net/phy/Kconfig        |   7 ++
>  drivers/net/phy/Makefile       |   1 +
>  drivers/net/phy/mdio-ipq40xx.c | 176 +++++++++++++++++++++++++++++++++
>  3 files changed, 184 insertions(+)
>  create mode 100644 drivers/net/phy/mdio-ipq40xx.c
> 
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index 3fa33d27eeba..815d52fa6080 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -157,6 +157,13 @@ config MDIO_I2C
>  
>  	  This is library mode.
>  
> +config MDIO_IPQ40XX
> +	tristate "Qualcomm IPQ40xx MDIO interface"
> +	depends on HAS_IOMEM && OF

You can drop the OF dependency here, of_mdiobus_register() becomes
mdiobus_register() with CONFIG_OF=n.

[snip]

> +static int ipq40xx_mdio_wait_busy(struct mii_bus *bus)
> +{
> +	struct ipq40xx_mdio_data *priv = bus->priv;
> +	int i;
> +
> +	for (i = 0; i < IPQ40XX_MDIO_RETRY; i++) {
> +		unsigned int busy;
> +
> +		busy = readl(priv->membase + MDIO_CTRL_4_REG) &
> +			MDIO_CTRL_4_ACCESS_BUSY;
> +		if (!busy)
> +			return 0;
> +
> +		/* BUSY might take to be cleard by 15~20 times of loop */

typo: cleard instead of cleared.

> +		udelay(IPQ40XX_MDIO_DELAY);
> +	}

consider using readl_poll_timeout() for this loop.

With that fixed:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian