netdev - Re: [PATCH bpf 2/2] selftests/bpf: Check for correct program attach/detach in xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW49m8Ke+kiuCvfPKdEefnON8_vb1bO6rfX5a7_ke=FSiw@mail.gmail.com>
Date:   Tue, 14 Apr 2020 15:30:17 -0700
From:   Song Liu <song@...nel.org>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH bpf 2/2] selftests/bpf: Check for correct program
 attach/detach in xdp_attach test

On Tue, Apr 14, 2020 at 9:20 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> David Ahern noticed that there was a bug in the EXPECTED_FD code so
> programs did not get detached properly when that parameter was supplied.
> This case was not included in the xdp_attach tests; so let's add it to be
> sure that such a bug does not sneak back in down.
>
> Fixes: 87854a0b57b3 ("selftests/bpf: Add tests for attaching XDP programs")
> Reported-by: David Ahern <dsahern@...il.com>
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>

Acked-by: Song Liu <songliubraving@...com>