netdev - Re: [PATCH] net/rds: Use ERR_PTR for rds_message_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Apr 2020 16:29:09 -0700
From:   santosh.shilimkar@...cle.com
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        rds-devel@....oracle.com
Subject: Re: [PATCH] net/rds: Use ERR_PTR for rds_message_alloc_sgs()

On 4/14/20 4:02 PM, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <jgg@...lanox.com>
> 
> Returning the error code via a 'int *ret' when the function returns a
> pointer is very un-kernely and causes gcc 10's static analysis to choke:
> 
> net/rds/message.c: In function ‘rds_message_map_pages’:
> net/rds/message.c:358:10: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    358 |   return ERR_PTR(ret);
> 
> Use a typical ERR_PTR return instead.
> 
> Signed-off-by: Jason Gunthorpe <jgg@...lanox.com>
> ---
Looks good Jason. Thanks !!

Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>