netdev - RE: [EXT] Re: [PATCH v3 2/7] qedf: Fix for the deviations from the SAM-4 spec.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR18MB25276120040AF0C600B8BC99D2DA0@MN2PR18MB2527.namprd18.prod.outlook.com>
Date:   Tue, 14 Apr 2020 04:20:20 +0000
From:   Saurav Kashyap <skashyap@...vell.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        Javed Hasan <jhasan@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v3 2/7] qedf: Fix for the deviations from the
 SAM-4 spec.

Hi Martin,

> -----Original Message-----
> From: Martin K. Petersen <martin.petersen@...cle.com>
> Sent: Tuesday, April 14, 2020 6:53 AM
> To: Saurav Kashyap <skashyap@...vell.com>
> Cc: martin.petersen@...cle.com; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@...vell.com>; linux-scsi@...r.kernel.org; Javed Hasan
> <jhasan@...vell.com>; netdev@...r.kernel.org
> Subject: [EXT] Re: [PATCH v3 2/7] qedf: Fix for the deviations from the SAM-4
> spec.
> 
> External Email
> 
> ----------------------------------------------------------------------
> 
> Saurav,
> 
> This should be 3 patches since there are 3 different functional
> changes.
> 
> > - Upper limit for retry delay(QEDF_RETRY_DELAY_MAX)
> >   increased from 20 sec to 1 min.
> 
> > - Log an event/message indicating throttling of I/O
> >   for the target and include scope and retry delay
> >   time returned by the target and the driver enforced delay.
> 
> > - Synchronizing the update of the fcport->retry_delay_timestamp
> >   between qedf_queuecommand() and qedf_scsi_completion().
> 
> "Synchronize".
> 
> Please describe why this needs to be synchronized.

<SK> Sure, Shall I need to submit full patch set again?

Thanks,
~Saurav
> 
> --
> Martin K. Petersen	Oracle Linux Engineering