netdev - Re: [PATCH] net/cxgb4: Check the return from t4_query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Apr 2020 16:46:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jgg@...pe.ca
Cc:     netdev@...r.kernel.org, vishal@...lsio.com
Subject: Re: [PATCH] net/cxgb4: Check the return from t4_query_params
 properly

From: Jason Gunthorpe <jgg@...pe.ca>
Date: Tue, 14 Apr 2020 12:27:08 -0300

> From: Jason Gunthorpe <jgg@...lanox.com>
> 
> Positive return values are also failures that don't set val,
> although this probably can't happen. Fixes gcc 10 warning:
> 
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c: In function ‘t4_phy_fw_ver’:
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3747:14: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>  3747 |  *phy_fw_ver = val;
> 
> Fixes: 01b6961410b7 ("cxgb4: Add PHY firmware support for T420-BT cards")
> Signed-off-by: Jason Gunthorpe <jgg@...lanox.com>

Applied, thanks.