netdev - Re: [PATCH net v2 2/2] net: dsa: Down cpu/dsa ports phylink will control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1057e139-a078-f411-b399-64b8c9181b2a@cogentembedded.com>
Date:   Tue, 14 Apr 2020 12:31:06 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net v2 2/2] net: dsa: Down cpu/dsa ports phylink will
 control

Hello!

   Only a couple grammar bugs... :-)

On 14.04.2020 3:34, Andrew Lunn wrote:

> DSA and CPU ports can be configured in two ways. By default, the
> driver should configure such ports to there maximum bandwidth. For
> most use cases, this is suficient. When this default is insufficient,

    Sufficient.

> a phylink instance can be bound to such ports, and phylink will
> configure the port, e.g. based on fixed-link properties. phylink
> assumes the port is initially down. Given that the driver should of

    Should have?

> already configured it to its maximum speed, ask the driver to down
> the port before instantiating the phylink instance.
> 
> Fixes: 30c4a5b0aad8 ("net: mv88e6xxx: use resolved link config in mac_link_up()")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
[...]

MBR, Sergei