netdev - Re: Correct tc-vlan usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hotSTzuj3mG53eGGy9i5pFSpb6RV51Kdo2xxeYUU9r-cw@mail.gmail.com>
Date:   Wed, 15 Apr 2020 21:14:57 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Edward Cree <ecree@...arflare.com>
Cc:     Jiri Pirko <jiri@...nulli.us>, netdev <netdev@...r.kernel.org>
Subject: Re: Correct tc-vlan usage

Hi Edward,

On Wed, 15 Apr 2020 at 21:13, Edward Cree <ecree@...arflare.com> wrote:
>
> On 15/04/2020 18:59, Vladimir Oltean wrote:
> > My problem is that the VLAN tags are discarded by the network
> > interface's RX filter:
> >
> > # ethtool -S eno2
> >      SI VLAN nomatch u-cast discards: 1280
> >
> > and this is because nobody calls .ndo_vlan_rx_add_vid for these VLANs
> > (only the 8021q driver does).
> You could try creating the VLAN interfaces anyway; no traffic will hit
>  them, because the tc rule popped the VLAN, but they'll call the ndo.
> Idk if that'll actually work though... and it'd still be possible to
>  TX through the VLAN devices, which you don't want.
>
> -ed

That is what I'm already doing. I'm keeping the VLAN subinterfaces
down and it works. It seems like misuse though...

Thanks,
-Vladimir