lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Apr 2020 09:37:08 +0800 From: maowenan <maowenan@...wei.com> To: Song Liu <songliubraving@...com> CC: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Martin Lau <kafai@...com>, Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>, "john.fastabend@...il.com" <john.fastabend@...il.com>, "kpsingh@...omium.org" <kpsingh@...omium.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH -next] bpf: remove set but not used variable 'dst_known' On 2020/4/15 6:05, Song Liu wrote: > > >> On Apr 13, 2020, at 4:37 AM, Mao Wenan <maowenan@...wei.com> wrote: >> >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> kernel/bpf/verifier.c:5603:18: warning: variable ‘dst_known’ >> set but not used [-Wunused-but-set-variable] >> >> It is not used since commit f1174f77b50c ("bpf/verifier: >> rework value tracking") > > The fix makes sense. But I think f1174f77b50c introduced dst_known, > so this statement is not accurate. > thanks for review, yes, f1174f77b50c introduced dst_known, and below commit doesn't deference variable dst_known. So I send v2 later? 3f50f132d840 ("bpf: Verifier, do explicit ALU32 bounds tracking") >> >> Signed-off-by: Mao Wenan <maowenan@...wei.com> >
Powered by blists - more mailing lists