netdev - Re: [PATCH] wimax/i2400m: Fix potential urb refcnt leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <517c4bae-d34c-855f-1872-2eed37eed54f@web.de>
Date:   Wed, 15 Apr 2020 11:12:51 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Xiyu Yang <xiyuyang19@...an.edu.cn>,
        Xin Tan <tanxin.ctf@...il.com>, linux-wimax@...el.com,
        netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Inaky Perez-Gonzalez <inaky.perez-gonzalez@...el.com>,
        Kangjie Lu <kjlu@....edu>, Yuan Zhang <yuanxzhang@...an.edu.cn>
Subject: Re: [PATCH] wimax/i2400m: Fix potential urb refcnt leak

> The issue happens in all paths of i2400mu_bus_bm_wait_for_ack(), which
> forget to decrease the refcnt increased by usb_get_urb(), causing a
> refcnt leak.

How do you think about to mention the term “reference counting” in
the commit message?

Would you like to add the tag “Fixes” to the change description?

Regards,
Markus