netdev - Re: [PATCH] batman-adv: Fix refcnt leak in batadv_store_throughput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <afea6694-36c6-bbae-dcfd-f6f6efedb05a@web.de>
Date:   Wed, 15 Apr 2020 13:10:07 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Xiyu Yang <xiyuyang19@...an.edu.cn>,
        Xin Tan <tanxin.ctf@...il.com>,
        b.a.t.m.a.n@...ts.open-mesh.org, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Antonio Quartulli <a@...table.cc>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Kangjie Lu <kjlu@....edu>,
        Marek Lindner <mareklindner@...mailbox.ch>,
        Simon Wunderlich <sw@...onwunderlich.de>,
        Sven Eckelmann <sven@...fation.org>,
        Yuan Zhang <yuanxzhang@...an.edu.cn>
Subject: Re: [PATCH] batman-adv: Fix refcnt leak in
 batadv_store_throughput_override

> The issue happens in one error path of
> batadv_store_throughput_override(). When batadv_parse_throughput()
> returns NULL, the refcnt increased by batadv_hardif_get_by_netdev() is
> not decreased, causing a refcnt leak.

How do you think about to mention the terms “exception handling”
and “reference counting” in the commit message?

Would you like to add the tag “Fixes” to the change description?

Regards,
Markus