netdev - Re: [PATCH net] amd-xgbe: Use __napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200416.140402.1289729188604088162.davem@davemloft.net>
Date:   Thu, 16 Apr 2020 14:04:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bigeasy@...utronix.de
Cc:     netdev@...r.kernel.org, thomas.lendacky@....com,
        tglx@...utronix.de, eric.dumazet@...il.com
Subject: Re: [PATCH net] amd-xgbe: Use __napi_schedule() in BH context

From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Date: Thu, 16 Apr 2020 17:57:40 +0200

> The driver uses __napi_schedule_irqoff() which is fine as long as it is
> invoked with disabled interrupts by everybody. Since the commit
> mentioned below the driver may invoke xgbe_isr_task() in tasklet/softirq
> context. This may lead to list corruption if another driver uses
> __napi_schedule_irqoff() in IRQ context.
> 
> Use __napi_schedule() which safe to use from IRQ and softirq context.
> 
> Fixes: 85b85c853401d ("amd-xgbe: Re-issue interrupt if interrupt status not cleared")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Acked-by: Tom Lendacky <thomas.lendacky@....com>

Applied and queued up for -stable, thanks.