netdev - Re: [PATCH RFC-v5 bpf-next 00/12] Add support for XDP in egress path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dc7e153-e455-ff6c-7013-edb7cb62b818@gmail.com>
Date:   Thu, 16 Apr 2020 17:55:28 -0600
From:   David Ahern <dsahern@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>,
        David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org,
        prashantbhole.linux@...il.com, jasowang@...hat.com,
        brouer@...hat.com, toshiaki.makita1@...il.com,
        daniel@...earbox.net, john.fastabend@...il.com, ast@...nel.org,
        kafai@...com, songliubraving@...com, yhs@...com, andriin@...com
Subject: Re: [PATCH RFC-v5 bpf-next 00/12] Add support for XDP in egress path

On 4/16/20 7:59 AM, Toke Høiland-Jørgensen wrote:
> 
> I like the choice of hook points. It is interesting that it implies that
> there will not be not a separate "XDP generic" hook on egress. And it's
> certainly a benefit to not have to change all the drivers. So that's
> good :)
> 
> I also think it'll be possible to get the information we want (such as
> TXQ fill level) at the places you put the hooks. For the skb case
> through struct netdev_queue and BQL, and for REDIRECT presumably with
> Magnus' queue abstraction once that lands. So overall I think we're
> getting there :)
> 
> I'll add a few more comments for each patch...
> 

thanks for reviewing.

FYI, somehow I left out a refactoring patch when generating patches to
send out. Basically moves existing tb[IFLA_XDP] handling to a helper
that can be reused for tb[IFLA_XDP_EGRESS]

https://github.com/dsahern/linux/commit/71011b5cf6f8c1bca28a6afe5a92be59152a8219