netdev - Re: [PATCH v4 9/9] qedf: Get dev info after updating the params.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76d84546-1587-41dd-647a-0fbbc581a086@cogentembedded.com>
Date:   Thu, 16 Apr 2020 12:41:16 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Saurav Kashyap <skashyap@...vell.com>, martin.petersen@...cle.com
Cc:     GR-QLogic-Storage-Upstream@...vell.com, linux-scsi@...r.kernel.org,
        jhasan@...vell.com, netdev@...r.kernel.org
Subject: Re: [PATCH v4 9/9] qedf: Get dev info after updating the params.

Hello!

On 16.04.2020 11:43, Saurav Kashyap wrote:

> An update to pf params can change the devinfo, get
> an updated device information.
> 
> Signed-off-by: Saurav Kashyap <skashyap@...vell.com>
> ---
>   drivers/scsi/qedf/qedf_main.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index 52673b4..dc5ac55 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -3332,6 +3332,13 @@ static int __qedf_probe(struct pci_dev *pdev, int mode)
>   	}
>   	qed_ops->common->update_pf_params(qedf->cdev, &qedf->pf_params);
>   
> +	/* Learn information crucial for qedf to progress */
> +	rc = qed_ops->fill_dev_info(qedf->cdev, &qedf->dev_info);
> +	if (rc) {
> +		QEDF_ERR(&qedf->dbg_ctx, "Failed to dev info.\n");

    "to fill dev info", perhaps?

[...]

MBR, Sergei