netdev - Re: [PATCH V4 17/19] net: ks8851: Separate SPI operations into separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88d884c9-84b1-ca31-17f2-a3769346e753@denx.de>
Date:   Thu, 16 Apr 2020 11:58:27 +0200
From:   Marek Vasut <marex@...x.de>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Petr Stetiar <ynezz@...e.cz>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH V4 17/19] net: ks8851: Separate SPI operations into
 separate file

On 4/15/20 4:56 PM, Lukas Wunner wrote:
> On Tue, Apr 14, 2020 at 08:20:27PM +0200, Marek Vasut wrote:
>> +static void __maybe_unused ks8851_done_tx(struct ks8851_net *ks,
> 
> If I'm not mistaken, the __maybe_unused is unnecessary here.
> Was added in v3.

It is necessary, because the header is included by the ks8851_common.c
as well as the ks8851_{par,spi,mll}.c, and it's only the later which use
that function. So this is needed to prevent a warning when building the
ks8851_common.c , where it is not used.

>> +#endif
> 
> A "/* __KS8851_H__ */" comment here would be nice.

OK