netdev - Re: WARNING in nf_nat_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200417213348.GC32392@breakpoint.cc>
Date:   Fri, 17 Apr 2020 23:33:48 +0200
From:   Florian Westphal <fw@...len.de>
To:     Hillf Danton <hdanton@...a.com>
Cc:     syzbot <syzbot+33e06702fd6cffc24c40@...kaller.appspotmail.com>,
        coreteam@...filter.org, davem@...emloft.net, fw@...len.de,
        kadlec@...filter.org, kuba@...nel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        netfilter-devel@...r.kernel.org, pablo@...filter.org,
        syzkaller-bugs@...glegroups.com
Subject: Re: WARNING in nf_nat_unregister_fn

Hillf Danton <hdanton@...a.com> wrote:
> In case of failure to register NFPROTO_IPV4, unregister NFPROTO_IPV6
> instead of ops->pf (== NFPROTO_INET).
> 
> --- a/net/netfilter/nf_nat_proto.c
> +++ b/net/netfilter/nf_nat_proto.c
> @@ -1022,8 +1022,8 @@ int nf_nat_inet_register_fn(struct net *
>  	ret = nf_nat_register_fn(net, NFPROTO_IPV4, ops, nf_nat_ipv4_ops,
>  				 ARRAY_SIZE(nf_nat_ipv4_ops));
>  	if (ret)
> -		nf_nat_ipv6_unregister_fn(net, ops);
> -
> +		nf_nat_unregister_fn(net, NFPROTO_IPV6, ops,
> +					ARRAY_SIZE(nf_nat_ipv6_ops));
>  	return ret;
>  }
>  EXPORT_SYMBOL_GPL(nf_nat_inet_register_fn);

Yes.  Please make a formal patch submission to netfilter-devel@,
including you signed-off-by, the Reported-by tag from syzbot
and a 'Fixes' tag for the buggy commit.

Thank you.