netdev - Re: [PATCH] can: tcan4x5x: Replace depends on REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Apr 2020 07:00:52 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        <linux-kernel@...r.kernel.org>
CC:     Collabora Kernel ML <kernel@...labora.com>,
        "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        <linux-can@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] can: tcan4x5x: Replace depends on REGMAP_SPI with depends
 on SPI

Enric

On 4/13/20 9:10 AM, Enric Balletbo i Serra wrote:
> regmap is a library function that gets selected by drivers that need
> it. No driver modules should depend on it. Instead depends on SPI and
> select REGMAP_SPI. Depending on REGMAP_SPI makes this driver only build
> if another driver already selected REGMAP_SPI, as the symbol can't be
> selected through the menu kernel configuration.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
>
>   drivers/net/can/m_can/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig
> index 1ff0b7fe81d6..c10932a7f1fe 100644
> --- a/drivers/net/can/m_can/Kconfig
> +++ b/drivers/net/can/m_can/Kconfig
> @@ -16,7 +16,8 @@ config CAN_M_CAN_PLATFORM
>   
>   config CAN_M_CAN_TCAN4X5X
>   	depends on CAN_M_CAN
> -	depends on REGMAP_SPI
> +	depends on SPI
> +	select REGMAP_SPI
>   	tristate "TCAN4X5X M_CAN device"
>   	---help---
>   	  Say Y here if you want support for Texas Instruments TCAN4x5x


Reviewed-by: Dan Murphy <dmurphy@...com>