netdev - Re: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba239f44-b3e4-723e-ad3d-3fbb90e8bfc1@microchip.com>
Date:   Fri, 17 Apr 2020 14:33:04 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Harini Katakam <harinik@...inx.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "pthombar@...ence.com" <pthombar@...ence.com>,
        "sergio.prado@...abworks.com" <sergio.prado@...abworks.com>,
        "antoine.tenart@...tlin.com" <antoine.tenart@...tlin.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "andrew@...n.ch" <andrew@...n.ch>,
        Michal Simek <michals@...inx.com>,
        Rafal Ozieblo <rafalo@...ence.com>
Subject: Re: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume
 routines

On 16/04/2020 at 20:26, Harini Katakam wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi Nicolas,
> 
>> -----Original Message-----
>> From: nicolas.ferre@...rochip.com [mailto:nicolas.ferre@...rochip.com]
>> Sent: Thursday, April 16, 2020 11:14 PM
>> To: linux-arm-kernel@...ts.infradead.org; netdev@...r.kernel.org; Claudiu
>> Beznea <claudiu.beznea@...rochip.com>; Harini Katakam
>> <harinik@...inx.com>
>> Cc: linux-kernel@...r.kernel.org; David S. Miller <davem@...emloft.net>;
>> Alexandre Belloni <alexandre.belloni@...tlin.com>; pthombar@...ence.com;
>> sergio.prado@...abworks.com; antoine.tenart@...tlin.com;
>> f.fainelli@...il.com; linux@...linux.org.uk; andrew@...n.ch; Michal Simek
>> <michals@...inx.com>; Nicolas Ferre <nicolas.ferre@...rochip.com>; Rafal
>> Ozieblo <rafalo@...ence.com>
>> Subject: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume
>> routines
>>
>> From: Nicolas Ferre <nicolas.ferre@...rochip.com>
>>
>> Use the proper struct device pointer to check if the wakeup flag and wakeup
>> source are positioned.
>> Use the one passed by function call which is equivalent to &bp->dev-
>>> dev.parent.
>>
>> It's preventing the trigger of a spurious interrupt in case the Wake-on-Lan
>> feature is used.
> 
> Sorry I have some mail issues; meant to reply earlier.
> Tested patches 1, 2, 3 in this set and they work for me.

Brilliant! Thanks for the feedback.

> I'll try patch 4; it looks similar to what I'm using locally but I'll add whatever
> tie-off queue handling is required on top of your series, thanks.

Alright, I'll hold my v2 for a few days then. Thanks. Best regards,
   Nicolas


-- 
Nicolas Ferre