netdev - Re: [PATCH net-next] net/mlx4_en: avoid indirect call in TX completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d4e865c-37c4-a4a7-81a2-3537ac14ae12@gmail.com>
Date:   Sat, 18 Apr 2020 15:37:10 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        tariqt@...lanox.com, willemb@...gle.com
Subject: Re: [PATCH net-next] net/mlx4_en: avoid indirect call in TX
 completion



On 4/18/20 3:31 PM, David Miller wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> Date: Wed, 15 Apr 2020 09:46:52 -0700
> 
>> Commit 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support")
>> brought another indirect call in fast path.
>>
>> Use INDIRECT_CALL_2() helper to avoid the cost of the indirect call
>> when/if CONFIG_RETPOLINE=y
>>
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> 
> I've decided to apply this to 'net' and queue it up for -stable, thanks.
> 

SGTM, thanks David !