netdev - Re: [PATCH net-next] dt-bindings: net: mdio: Document common properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200418143511.GE804711@lunn.ch>
Date:   Sat, 18 Apr 2020 16:35:11 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] dt-bindings: net: mdio: Document common
 properties

On Fri, Apr 17, 2020 at 05:51:26PM -0700, Florian Fainelli wrote:
> Some of the properties pertaining to the broken turn around or resets
> were only documented in ethernet-phy.yaml while they are applicable
> across all MDIO devices and not Ethernet PHYs specifically which are a
> superset.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  .../devicetree/bindings/net/mdio.yaml         | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml
> index 50c3397a82bc..58d486db5651 100644
> --- a/Documentation/devicetree/bindings/net/mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/mdio.yaml
> @@ -50,6 +50,33 @@ patternProperties:
>          description:
>            The ID number for the PHY.
>  
> +      broken-turn-around:
> +        $ref: /schemas/types.yaml#definitions/flag
> +        description:
> +          If set, indicates the PHY device does not correctly release
> +          the turn around line low at the end of a MDIO transaction.

Hi Florian

Since this is a generic property, maybe this should be "the MDIO
device"? Probably the whole document needs s/PHY/MDIO/g ?

	 Andrew