netdev - Re: [PATCH] net: openvswitch: ovs_ct_exit to be done under ovs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_CjZ1oyNyuj7tgZLZ1XXFahCSO76BfHX7YFo_O68FfrXQ@mail.gmail.com>
Date:   Sun, 19 Apr 2020 10:32:30 -0700
From:   Pravin Shelar <pravin.ovn@...il.com>
To:     Tonghao Zhang <xiangxia.m.yue@...il.com>
Cc:     syzbot+7ef50afd3a211f879112@...kaller.appspotmail.com,
        "David S. Miller" <davem@...emloft.net>,
        ovs dev <dev@...nvswitch.org>, kuba@...nel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        syzkaller-bugs@...glegroups.com, Yi-Hung Wei <yihung.wei@...il.com>
Subject: Re: [PATCH] net: openvswitch: ovs_ct_exit to be done under ovs_lock

On Sun, Apr 19, 2020 at 1:44 AM <xiangxia.m.yue@...il.com> wrote:
>
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
>
> syzbot wrote:
> | =============================
> | WARNING: suspicious RCU usage
> | 5.7.0-rc1+ #45 Not tainted
> | -----------------------------
> | net/openvswitch/conntrack.c:1898 RCU-list traversed in non-reader section!!
> |
> | other info that might help us debug this:
> | rcu_scheduler_active = 2, debug_locks = 1
> | ...
> |
> | stack backtrace:
> | Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-0-ga698c8995f-prebuilt.qemu.org 04/01/2014
> | Workqueue: netns cleanup_net
> | Call Trace:
> | ...
> | ovs_ct_exit
> | ovs_exit_net
> | ops_exit_list.isra.7
> | cleanup_net
> | process_one_work
> | worker_thread
>
> To avoid that warning, invoke the ovs_ct_exit under ovs_lock and add
> lockdep_ovsl_is_held as optional lockdep expression.
>
> Link: https://lore.kernel.org/lkml/000000000000e642a905a0cbee6e@google.com
> Fixes: 11efd5cb04a1 ("openvswitch: Support conntrack zone limit")
> Cc: Pravin B Shelar <pshelar@....org>
> Cc: Yi-Hung Wei <yihung.wei@...il.com>
> Reported-by: syzbot+7ef50afd3a211f879112@...kaller.appspotmail.com
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>

Acked-by: Pravin B Shelar <pshelar@....org>

Thanks.