netdev - Re: [PATCH net-next 0/4] r8169: improve memory barriers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Apr 2020 20:11:06 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        David Miller <davem@...emloft.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] r8169: improve memory barriers

On 19.04.2020 19:38, Heiner Kallweit wrote:
> This series includes improvements for (too heavy) memory barriers.
> Tested on x86-64 with RTL8168g chip version.
> 
> Heiner Kallweit (4):
>   r8169: use smp_store_mb in rtl_tx
>   r8169: change wmb to dma_wmb in rtl8169_start_xmit

I think I'll have to drip this patch from the series. These Realtek
chips are also used on non-x86 platforms, and these platforms may
not be coherent. I'll send a v2.

>   r8169: replace dma_rmb with READ_ONCE in rtl_rx
>   r8169: use WRITE_ONCE instead of dma_wmb in rtl8169_mark_to_asic
> 
>  drivers/net/ethernet/realtek/r8169_main.c | 26 ++++++++---------------
>  1 file changed, 9 insertions(+), 17 deletions(-)
>