netdev - Re: [PATCH] net: phy: marvell10g: hwmon support for 2110

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87blnoc6ua.fsf@tarshish>
Date:   Sun, 19 Apr 2020 09:44:45 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH] net: phy: marvell10g: hwmon support for 2110

Hi Andrew,

On Fri, Apr 17 2020, Andrew Lunn wrote:
> On Fri, Apr 17, 2020 at 09:10:52AM +0300, Baruch Siach wrote:
>> Read the temperature sensor register from the correct location for the
>> 88E2110 PHY. There is no enable/disable bit, so leave
>> mv3310_hwmon_config() for 88X3310 only.
>
> Nice. Thanks for doing this.
>
>> @@ -191,7 +201,8 @@ static int mv3310_hwmon_probe(struct phy_device *phydev)
>>  	struct mv3310_priv *priv = dev_get_drvdata(&phydev->mdio.dev);
>>  	int i, j, ret;
>>  
>> -	if (phydev->drv->phy_id != MARVELL_PHY_ID_88X3310)
>> +	if (phydev->drv->phy_id != MARVELL_PHY_ID_88X3310 &&
>> +			phydev->drv->phy_id != MARVELL_PHY_ID_88E2110)
>>  		return 0;
>
> The indentation looks wrong here?

Indeed. Should I respin?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -