netdev - Re: [PATCH AUTOSEL 5.5 006/106] net/mlx5e: Enforce setting of a single FEC mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Apr 2020 12:05:45 +0300
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Sasha Levin <sashal@...nel.org>
Cc:     Stable <stable@...r.kernel.org>, Aya Levin <ayal@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 5.5 006/106] net/mlx5e: Enforce setting of a
 single FEC mode

On Sun, Apr 19, 2020 at 12:20 AM Sasha Levin <sashal@...nel.org> wrote:
> On Sat, Apr 18, 2020 at 10:52:59PM +0300, Or Gerlitz wrote:
> >On Thu, Apr 16, 2020 at 2:56 AM Sasha Levin <sashal@...nel.org> wrote:
> >> From: Aya Levin <ayal@...lanox.com>
> >> [ Upstream commit 4bd9d5070b92da012f2715cf8e4859acb78b8f35 ]
> >>
> >> Ethtool command allow setting of several FEC modes in a single set
> >> command. The driver can only set a single FEC mode at a time. With this
> >> patch driver will reply not-supported on setting several FEC modes.
> >>
> >> Signed-off-by: Aya Levin <ayal@...lanox.com>
> >> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> >> Signed-off-by: Sasha Levin <sashal@...nel.org>
> >> ---
> >>  drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++++
> >
> >Haven't we agreed that drivers/net/ethernet/mellanox/mlx5 is not
> >subject to autosel anymore?!
>
> On Thu, Apr 16, 2020 at 09:08:06PM +0000, Saeed Mahameed wrote:
> >Please don't opt mlx5 out just yet ;-), i need to do some more research
> >and make up my mind..
>
> It would be awesome if the Mellanox folks could agree between
> themselves whether they want it or not and let us know which option they
> pick.

My reply did had a question mark. I missed remembering this response
from Saeed over the other thread and remembered your "no problem opting
it out" response.

> Again, I really don't care whether mlx5 is opted out or not, I'm not
> going to argue with anyone if you want to opt out, I just want to know
> whether you're out or not :)

let us continue on the other thread, I think whole netdev (net + drivers)
should be opted out by default and only on those folders you get ack
from the subsystem maintainer and driver maintainer you can opt in.