netdev - Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3f6a008696d87acb67db06c21eb600d@piie.net>
Date:   Sun, 19 Apr 2020 13:50:35 +0000
From:   "Peter Kästle" <peter@...e.net>
To:     "Andrzej Pietrasiewicz" <andrzej.p@...labora.com>,
        linux-pm@...r.kernel.org
Cc:     "Zhang Rui" <rui.zhang@...el.com>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        "Len Brown" <lenb@...nel.org>, "Jiri Pirko" <jiri@...lanox.com>,
        "Ido Schimmel" <idosch@...lanox.com>,
        "David S . Miller" <davem@...emloft.net>,
        "Darren Hart" <dvhart@...radead.org>,
        "Andy Shevchenko" <andy@...radead.org>,
        "Support Opensource" <support.opensource@...semi.com>,
        "Daniel Lezcano" <daniel.lezcano@...aro.org>,
        "Amit Kucheria" <amit.kucheria@...durent.com>,
        "Shawn Guo" <shawnguo@...nel.org>,
        "Sascha Hauer" <s.hauer@...gutronix.de>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        "Fabio Estevam" <festevam@...il.com>,
        "NXP Linux Team" <linux-imx@....com>,
        "Allison Randal" <allison@...utok.net>,
        "Enrico Weigelt" <info@...ux.net>,
        "Gayatri Kammela" <gayatri.kammela@...el.com>,
        "Thomas Gleixner" <tglx@...utronix.de>, linux-acpi@...r.kernel.org,
        netdev@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, kernel@...labora.com,
        "Barlomiej Zolnierkiewicz" <b.zolnierkie@...sung.com>
Subject: Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be
 stored in its struct

17. April 2020 18:20, "Andrzej Pietrasiewicz" <andrzej.p@...labora.com> schrieb:

> Thermal zone devices' mode is stored in individual drivers. This patch
> changes it so that mode is stored in struct thermal_zone_device instead.
> 
> As a result all driver-specific variables storing the mode are not needed
> and are removed. Consequently, the get_mode() implementations have nothing
> to operate on and need to be removed, too.
> 
> Some thermal framework specific functions are introduced:
> 
> thermal_zone_device_get_mode()
> thermal_zone_device_set_mode()
> thermal_zone_device_enable()
> thermal_zone_device_disable()
> 
> thermal_zone_device_get_mode() and its "set" counterpart take tzd's lock
> and the "set" calls driver's set_mode() if provided, so the latter must
> not take this lock again. At the end of the "set"
> thermal_zone_device_update() is called so drivers don't need to repeat this
> invocation in their specific set_mode() implementations.
> 
> The scope of the above 4 functions is purposedly limited to the thermal
> framework and drivers are not supposed to call them. This encapsulation
> does not fully work at the moment for some drivers, though:
> 
> - platform/x86/acerhdf.c

Acked-by: Peter Kaestle <peter@...e.net>

[...]

-- 
--peter;