netdev - Re: [PATCH net] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3980eea4-18d8-5e62-2d6d-fce0a7e7ed4c@solarflare.com>
Date:   Mon, 20 Apr 2020 13:28:22 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Jiri Pirko <jiri@...nulli.us>,
        Pablo Neira Ayuso <pablo@...filter.org>
CC:     <netfilter-devel@...r.kernel.org>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <kuba@...nel.org>
Subject: Re: [PATCH net] net: flow_offload: skip hw stats check for
 FLOW_ACTION_HW_STATS_DISABLED

On 20/04/2020 12:52, Jiri Pirko wrote:
> However for TC, when user specifies "HW_STATS_DISABLED", the driver
> should not do stats.
What should a driver do if the user specifies DISABLED, but the stats
 are still needed for internal bookkeeping (e.g. to prod an ARP entry
 that's in use for encapsulation offload, so that it doesn't get
 expired out of the cache)?  Enable the stats on the HW anyway but
 not report them to FLOW_CLS_STATS?  Or return an error?

-ed