netdev - Re: [PATCH] net: stmmac: dwmac-meson8b: Add missing boundary to RGMII TX clock array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200420.111111.1335274381489892106.davem@davemloft.net>
Date:   Mon, 20 Apr 2020 11:11:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     maz@...nel.org
Cc:     netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, peppe.cavallaro@...com,
        alexandre.torgue@...com, joabreu@...opsys.com,
        khilman@...libre.com, martin.blumenstingl@...glemail.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-meson8b: Add missing boundary to
 RGMII TX clock array

From: Marc Zyngier <maz@...nel.org>
Date: Sat, 18 Apr 2020 19:14:57 +0100

> Running with KASAN on a VIM3L systems leads to the following splat
> when probing the Ethernet device:
> 
> ==================================================================
> BUG: KASAN: global-out-of-bounds in _get_maxdiv+0x74/0xd8
> Read of size 4 at addr ffffa000090615f4 by task systemd-udevd/139
> CPU: 1 PID: 139 Comm: systemd-udevd Tainted: G            E     5.7.0-rc1-00101-g8624b7577b9c #781
> Hardware name: amlogic w400/w400, BIOS 2020.01-rc5 03/12/2020
...
> Digging into this indeed shows that the clock divider array is
> lacking a final fence, and that the clock subsystems goes in the
> weeds. Oh well.
> 
> Let's add the empty structure that indicates the end of the array.
> 
> Fixes: bd6f48546b9c ("net: stmmac: dwmac-meson8b: Fix the RGMII TX delay on Meson8b/8m2 SoCs")
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> Cc: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Cc: stable@...r.kernel.org

Please do not CC: stable@...r.kernel.org for networking changes as per
netdev-FAQ

Applied and queued up for -stable, thanks.