lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Apr 2020 10:48:26 +0800 (GMT+08:00) From: 易林 <yilin@....ac.cn> To: vishal@...lsio.com Cc: "csong@...ucr.edu" <csong@...ucr.edu>, "yiqiuping@...il.com" <yiqiuping@...il.com>, "zhiyunq@...ucr.edu" <zhiyunq@...ucr.edu>, "jian liu" <liujian6@....ac.cn>, netdev@...r.kernel.org Subject: drivers: target: iscsi: cxgbit: is there exist a memleak in cxgbit_create_server4? static int cxgbit_create_server4(struct cxgbit_device *cdev, unsigned int stid, struct cxgbit_np *cnp) { struct sockaddr_in *sin = (struct sockaddr_in *) &cnp->com.local_addr; int ret; pr_debug("%s: dev = %s; stid = %u; sin_port = %u\n", __func__, cdev->lldi.ports[0]->name, stid, sin->sin_port); cxgbit_get_cnp(cnp); cxgbit_init_wr_wait(&cnp->com.wr_wait); ret = cxgb4_create_server(cdev->lldi.ports[0], stid, sin->sin_addr.s_addr, sin->sin_port, 0, cdev->lldi.rxq_ids[0]); if (!ret) ret = cxgbit_wait_for_reply(cdev, &cnp->com.wr_wait, 0, 10, __func__); else if (ret > 0) ret = net_xmit_errno(ret); else cxgbit_put_cnp(cnp); if (ret) pr_err("create server failed err %d stid %d laddr %pI4 lport %d\n", ret, stid, &sin->sin_addr, ntohs(sin->sin_port)); return ret; } what if cxgb4_create_server return a >0 value, the cnp reference wouldn't be released. Or, when cxgb4_create_server return >0 value, cnp has been released somewhere.
Powered by blists - more mailing lists