netdev - RE: [EXT] [PATCH] qed: use true,false for bool variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR18MB31825BA5D9769293119AB240A1D40@MN2PR18MB3182.namprd18.prod.outlook.com>
Date:   Mon, 20 Apr 2020 04:41:02 +0000
From:   Michal Kalderon <mkalderon@...vell.com>
To:     Jason Yan <yanaijie@...wei.com>, Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] qed: use true,false for bool variables

> From: Jason Yan <yanaijie@...wei.com>
> Sent: Monday, April 20, 2020 7:27 AM
> 
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
> 
> drivers/net/ethernet/qlogic/qed/qed_dev.c:4395:2-34: WARNING:
> Assignment of 0/1 to bool variable
> drivers/net/ethernet/qlogic/qed/qed_dev.c:1975:2-34: WARNING:
> Assignment of 0/1 to bool variable
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_dev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c
> b/drivers/net/ethernet/qlogic/qed/qed_dev.c
> index 38a65b984e47..7119a18af19e 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
> @@ -1972,7 +1972,7 @@ static int qed_init_qm_sanity(struct qed_hwfn
> *p_hwfn)
>  		return 0;
> 
>  	if (QED_IS_ROCE_PERSONALITY(p_hwfn)) {
> -		p_hwfn->hw_info.multi_tc_roce_en = 0;
> +		p_hwfn->hw_info.multi_tc_roce_en = false;
>  		DP_NOTICE(p_hwfn,
>  			  "multi-tc roce was disabled to reduce requested
> amount of pqs\n");
>  		if (qed_init_qm_get_num_pqs(p_hwfn) <=
> RESC_NUM(p_hwfn, QED_PQ)) @@ -4392,7 +4392,7 @@
> qed_get_hw_info(struct qed_hwfn *p_hwfn,
>  	}
> 
>  	if (QED_IS_ROCE_PERSONALITY(p_hwfn))
> -		p_hwfn->hw_info.multi_tc_roce_en = 1;
> +		p_hwfn->hw_info.multi_tc_roce_en = true;
> 
>  	p_hwfn->hw_info.num_hw_tc = NUM_PHYS_TCS_4PORT_K2;
>  	p_hwfn->hw_info.num_active_tc = 1;
> --
> 2.21.1

Thanks, 

Acked-by: Michal Kalderon <michal.kalderon@...vell.com>