netdev - RE: [EXT] [PATCH net-next v3 0/3] FEC MDIO speedups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HE1PR0402MB2745765C4F546A8395FC09E8FFD40@HE1PR0402MB2745.eurprd04.prod.outlook.com>
Date:   Mon, 20 Apr 2020 01:42:47 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
CC:     netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: RE: [EXT] [PATCH net-next v3 0/3]  FEC MDIO speedups

From: Andrew Lunn <andrew@...n.ch> Sent: Monday, April 20, 2020 6:04 AM
> This patchset gives a number of speedups for MDIO with the FEC.
> Replacing interrupt driven with polled IO brings a big speedup due to the
> overheads of interrupts compared to the short time interval.
> Clocking the bus faster, when the MDIO targets supports it, can double the
> transfer rate. And suppressing the preamble, if devices support it, makes each
> transaction faster.
> 
> By default the MDIO clock remains 2.5MHz and preables are used. But these
> can now be controlled from the device tree. Since these are generic
> properties applicable to more than just FEC, these have been added to the
> generic MDIO binding documentation.
> 
> v2:
> readl_poll_timeout()
> Add patches to set bus frequency and preamble disable
> 
> v3:
> Add Reviewed tags
> uS->us
> readl_poll_timeout_atomic()
> Extend DT binding documentation
> 
> Andrew Lunn (3):
>   net: ethernet: fec: Replace interrupt driven MDIO with polled IO
>   net: ethernet: fec: Allow configuration of MDIO bus speed
>   net: ethernet: fec: Allow the MDIO preamble to be disabled

The v3 version seems good.
Thanks, Andrew.

Acked-by: Fugang Duan <fugang.duan@....com>
> 
>  .../devicetree/bindings/net/fsl-fec.txt       |  1 +
>  .../devicetree/bindings/net/mdio.yaml         | 12 +++
>  drivers/net/ethernet/freescale/fec.h          |  4 +-
>  drivers/net/ethernet/freescale/fec_main.c     | 85 +++++++++++--------
>  4 files changed, 63 insertions(+), 39 deletions(-)
> 
> --
> 2.26.1