netdev - Re: [PATCH] net: ethernet: ixp4xx: Add error handling inixp4xx_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200421100544.0de3fbba@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 21 Apr 2020 10:05:44 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tang Bin <tangbin@...s.chinamobile.com>
Cc:     khalasa@...p.pl, davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shengju Zhang <zhangshengju@...s.chinamobile.com>
Subject: Re: [PATCH] net: ethernet: ixp4xx: Add error handling
 inixp4xx_eth_probe()

On Tue, 21 Apr 2020 12:46:37 +0800 Tang Bin wrote:
> Hi Jakub:
> 
> On 2020/4/13 2:35, Jakub Kicinski wrote:
> > On Sun, 12 Apr 2020 17:27:28 +0800 Tang Bin wrote:  
> >> The function ixp4xx_eth_probe() does not perform sufficient error
> >> checking after executing devm_ioremap_resource(),which can result
> >> in crashes if a critical error path is encountered.
> >>  
> > Please provide an appropriate Fixes: tag.  
> 
> Thanks for your reply.
> 
> I don't know whether the commit message affect this patch's result. If so,
> 
> I think the commit message in v2 needs more clarification. As follows:
> 
>      The function ixp4xx_eth_probe() does not perform sufficient error 
> checking
> 
> after executing devm_ioremap_resource(), which can result in crashes if 
> a critical
> 
> error path is encountered.
> 
>      Fixes: f458ac479777 ("ARM/net: ixp4xx: Pass ethernet physical base 
> as resource").
> 
> 
> I'm waiting for you reply actively.

Please repost with the tag included.