netdev - Re: [PATCH net] macvlan: fix null dereference in macvlan_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200421.155253.404301761880711135.davem@davemloft.net>
Date:   Tue, 21 Apr 2020 15:52:53 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     kuba@...nel.org, dingtianhong@...wei.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] macvlan: fix null dereference in
 macvlan_device_event()

From: Taehee Yoo <ap420073@...il.com>
Date: Mon, 20 Apr 2020 13:29:40 +0000

> In the macvlan_device_event(), the list_first_entry_or_null() is used.
> This function could return null pointer if there is no node.
> But, the macvlan module doesn't check the null pointer.
> So, null-ptr-deref would occur.
> 
>       bond0
>         |
>    +----+-----+
>    |          |
> macvlan0   macvlan1
>    |          |
>  dummy0     dummy1
> 
> The problem scenario.
 ...
> Test commands:
 ...
> Splat looks like:
 ...
> Fixes: e289fd28176b ("macvlan: fix the problem when mac address changes for passthru mode")
> Reported-by: syzbot+5035b1f9dc7ea4558d5a@...kaller.appspotmail.com
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied and queued up for -stable, thank you.