lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Apr 2020 23:27:13 +0000 From: "Ertman, David M" <david.m.ertman@...el.com> To: Jason Gunthorpe <jgg@...pe.ca>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com> CC: "davem@...emloft.net" <davem@...emloft.net>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "nhorman@...hat.com" <nhorman@...hat.com>, "sassmann@...hat.com" <sassmann@...hat.com>, "parav@...lanox.com" <parav@...lanox.com>, "galpress@...zon.com" <galpress@...zon.com>, "selvin.xavier@...adcom.com" <selvin.xavier@...adcom.com>, "sriharsha.basavapatna@...adcom.com" <sriharsha.basavapatna@...adcom.com>, "benve@...co.com" <benve@...co.com>, "bharat@...lsio.com" <bharat@...lsio.com>, "xavier.huwei@...wei.com" <xavier.huwei@...wei.com>, "yishaih@...lanox.com" <yishaih@...lanox.com>, "leonro@...lanox.com" <leonro@...lanox.com>, "mkalderon@...vell.com" <mkalderon@...vell.com>, "aditr@...are.com" <aditr@...are.com>, "ranjani.sridharan@...ux.intel.com" <ranjani.sridharan@...ux.intel.com>, "pierre-louis.bossart@...ux.intel.com" <pierre-louis.bossart@...ux.intel.com>, "Patil, Kiran" <kiran.patil@...el.com>, "Bowers, AndrewX" <andrewx.bowers@...el.com> Subject: RE: [net-next v2 1/9] Implementation of Virtual Bus > -----Original Message----- > From: Jason Gunthorpe <jgg@...pe.ca> > Sent: Tuesday, April 21, 2020 5:09 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com> > Cc: davem@...emloft.net; gregkh@...uxfoundation.org; Ertman, David M > <david.m.ertman@...el.com>; netdev@...r.kernel.org; linux- > rdma@...r.kernel.org; nhorman@...hat.com; sassmann@...hat.com; > parav@...lanox.com; galpress@...zon.com; > selvin.xavier@...adcom.com; sriharsha.basavapatna@...adcom.com; > benve@...co.com; bharat@...lsio.com; xavier.huwei@...wei.com; > yishaih@...lanox.com; leonro@...lanox.com; mkalderon@...vell.com; > aditr@...are.com; ranjani.sridharan@...ux.intel.com; pierre- > louis.bossart@...ux.intel.com; Patil, Kiran <kiran.patil@...el.com>; Bowers, > AndrewX <andrewx.bowers@...el.com> > Subject: Re: [net-next v2 1/9] Implementation of Virtual Bus > > On Tue, Apr 21, 2020 at 01:02:27AM -0700, Jeff Kirsher wrote: > > +/** > > + * virtbus_release_device - Destroy a virtbus device > > + * @_dev: device to release > > + */ > > +static void virtbus_release_device(struct device *_dev) > > +{ > > + struct virtbus_device *vdev = to_virtbus_dev(_dev); > > + int ida = vdev->id; > > + > > + vdev->release(vdev); > > + ida_simple_remove(&virtbus_dev_ida, ida); > > +} > > + > > +/** > > + * virtbus_register_device - add a virtual bus device > > + * @vdev: virtual bus device to add > > + */ > > +int virtbus_register_device(struct virtbus_device *vdev) > > +{ > > + int ret; > > + > > + if (!vdev->release) { > > + dev_err(&vdev->dev, "virtbus_device MUST have a .release > callback that does something.\n"); > > + return -EINVAL; > > + } > > + > > + /* Don't return on error here before the device_initialize. > > + * All error paths out of this function must perform a > > + * put_device(), unless the release callback does not exist, > > + * so that the .release() callback is called, and thus have > > + * to occur after the device_initialize. > > + */ > > + device_initialize(&vdev->dev); > > + > > + vdev->dev.bus = &virtual_bus_type; > > + vdev->dev.release = virtbus_release_device; > > + > > + /* All device IDs are automatically allocated */ > > + ret = ida_simple_get(&virtbus_dev_ida, 0, 0, GFP_KERNEL); > > + > > + if (ret < 0) { > > + dev_err(&vdev->dev, "get IDA idx for virtbus device > failed!\n"); > > + goto device_pre_err; > > This still has the problem I described, why are you resending without > fixing? > > Jason Fix should be in the next revision - sorry for the confusion. -DaveE
Powered by blists - more mailing lists