netdev - Re: [PATCH v2 2/3] Bluetooth: hci_h5: Add support for binding RTL8723BS with device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202004211651.kHDo3kEv%lkp@intel.com>
Date:   Tue, 21 Apr 2020 16:05:38 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Alistair Francis <alistair@...stair23.me>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, marcel@...tmann.org,
        johan.hedberg@...il.com, linux-bluetooth@...r.kernel.org,
        mripard@...nel.org, wens@...e.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        anarsoul@...il.com, devicetree@...r.kernel.org,
        alistair23@...il.com, linux-arm-kernel@...ts.infradead.org,
        Alistair Francis <alistair@...stair23.me>
Subject: Re: [PATCH v2 2/3] Bluetooth: hci_h5: Add support for binding
 RTL8723BS with device tree

Hi Alistair,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on net-next/master v5.7-rc2 next-20200420]
[cannot apply to bluetooth/master ipvs/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Alistair-Francis/dt-bindings-net-bluetooth-Add-rtl8723bs-bluetooth/20200407-140111
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git aa81700cf2326e288c9ca1fe7b544039617f1fc2
config: arm64-randconfig-a001-20200421 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a9b137f9ffba8cb25dfd7dd1fb613e8aac121b37)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/bluetooth/hci_h5.c:1023:27: error: use of undeclared identifier 'rtl_vnd'
             .data = (const void *)&rtl_vnd },
                                    ^
>> drivers/bluetooth/hci_h5.c:1026:1: error: definition of variable with array type needs an explicit size or an initializer
   MODULE_DEVICE_TABLE(of, rtl_bluetooth_of_match);
   ^
   include/linux/module.h:240:21: note: expanded from macro 'MODULE_DEVICE_TABLE'
   extern typeof(name) __mod_##type##__##name##_device_table               \
                       ^
   <scratch space>:85:1: note: expanded from here
   __mod_of__rtl_bluetooth_of_match_device_table
   ^
   2 errors generated.

vim +1026 drivers/bluetooth/hci_h5.c

28a75e4c813c7ae Hans de Goede     2018-10-30  1016  
848fc6164158d69 Max Chou          2020-02-17  1017  static const struct of_device_id rtl_bluetooth_of_match[] = {
848fc6164158d69 Max Chou          2020-02-17  1018  #ifdef CONFIG_BT_HCIUART_RTL
848fc6164158d69 Max Chou          2020-02-17  1019  	{ .compatible = "realtek,rtl8822cs-bt",
848fc6164158d69 Max Chou          2020-02-17  1020  	  .data = (const void *)&rtl_vnd },
848fc6164158d69 Max Chou          2020-02-17  1021  #endif
025703659453391 Vasily Khoruzhick 2020-04-06  1022  	{ .compatible = "realtek,rtl8822bs-bt",
025703659453391 Vasily Khoruzhick 2020-04-06  1023  	  .data = (const void *)&rtl_vnd },
848fc6164158d69 Max Chou          2020-02-17  1024  	{ },
848fc6164158d69 Max Chou          2020-02-17  1025  };
848fc6164158d69 Max Chou          2020-02-17 @1026  MODULE_DEVICE_TABLE(of, rtl_bluetooth_of_match);
848fc6164158d69 Max Chou          2020-02-17  1027  

:::::: The code at line 1026 was first introduced by commit
:::::: 848fc6164158d697b70b390a2db5019663713f47 Bluetooth: hci_h5: btrtl: Add support for RTL8822C

:::::: TO: Max Chou <max.chou@...ltek.com>
:::::: CC: Marcel Holtmann <marcel@...tmann.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (40230 bytes)