netdev - RE: [RFC PATCH v5 12/16] RDMA/irdma: Add miscellaneous utility definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Apr 2020 00:02:14 +0000
From:   "Saleem, Shiraz" <shiraz.saleem@...el.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [RFC PATCH v5 12/16] RDMA/irdma: Add miscellaneous utility
 definitions

> Subject: Re: [RFC PATCH v5 12/16] RDMA/irdma: Add miscellaneous utility
> definitions
> 

[...]
> > > > + * irdma_arp_table -manage arp table
> > > > + * @rf: RDMA PCI function
> > > > + * @ip_addr: ip address for device
> > > > + * @ipv4: IPv4 flag
> > > > + * @mac_addr: mac address ptr
> > > > + * @action: modify, delete or add  */ int irdma_arp_table(struct
> > > > +irdma_pci_f *rf, u32 *ip_addr, bool ipv4,
> > > > +		    u8 *mac_addr, u32 action)
> > >
> > > ARP table in the RDMA driver looks strange, I see that it is legacy
> > > from i40iw, but wonder if it is the right thing to do the same for the new driver.
> > >
> >
> > See response in Patch #1.
> 
> OK, let's me rephrase the question.
> Why can't you use arp_tbl from include/net/arp.h and need to implement it in the
> RDMA driver?
> 

The driver needs to track the on-chip arp cache indices and program the
index & entry via rdma admin queue cmd. These indices are specific to our hw
arp cache and not the system arp table. So I am not sure how we can use it.