netdev - Re: [PATCH V4 mlx5-next 00/15] Add support to get xmit slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa7a1940-90f8-b0d1-b211-a5bb27592b5a@mellanox.com>
Date:   Wed, 22 Apr 2020 15:56:20 +0300
From:   Maor Gottlieb <maorg@...lanox.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     davem@...emloft.net, jgg@...lanox.com, dledford@...hat.com,
        j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net,
        kuba@...nel.org, jiri@...lanox.com, dsahern@...nel.org,
        leonro@...lanox.com, saeedm@...lanox.com,
        linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        alexr@...lanox.com
Subject: Re: [PATCH V4 mlx5-next 00/15] Add support to get xmit slave


On 4/22/2020 3:46 PM, Jiri Pirko wrote:
> Wed, Apr 22, 2020 at 10:39:36AM CEST, maorg@...lanox.com wrote:
>
> [...]
>
>> Change log:
>> v4: 1. Rename master_get_xmit_slave to netdev_get_xmit_slave and move the implementation to dev.c
>>     2. Remove unnecessary check of NULL pointer.
>>     3. Fix typo.
> It is really hard to follow the changes if you don't have the changelog
> per patch. Could you have it per patch next time please?

Sure.
>
>
>> v3: 1. Move master_get_xmit_slave to netdevice.h and change the flags arg.
>> to bool.
>>     2. Split helper functions commit to multiple commits for each bond
>> mode.
>>     3. Extract refcotring changes to seperate commits.
>> v2: The first patch wasn't sent in v1.
>> v1: https://lore.kernel.org/netdev/ac373456-b838-29cf-645f-b1ea1a93e3b0@gmail.com/T/#t
>>