netdev - Re: [PATCH ipsec-next v2 2/2] xfrm: add IPv6 support for espintcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200422153136.GA4098331@bistromath.localdomain>
Date:   Wed, 22 Apr 2020 17:31:36 +0200
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Steffen Klassert <steffen.klassert@...unet.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ipsec-next v2 2/2] xfrm: add IPv6 support for espintcp

2020-04-22, 13:05:41 +0200, Steffen Klassert wrote:
> On Tue, Apr 21, 2020 at 06:04:23PM +0200, Sabrina Dubroca wrote:
> > This extends espintcp to support IPv6, building on the existing code
> > and the new UDPv6 encapsulation support. Most of the code is either
> > reused directly (stream parser, ULP) or very similar to the IPv4
> > variant (net/ipv6/esp6.c changes).
> > 
> > The separation of config options for IPv4 and IPv6 espintcp requires a
> > bit of Kconfig gymnastics to enable the core code.
> > 
> > Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
> 
> This patch does not apply on top of patch 1/2:
> 
> git am -s ~/Mail/todo-ipsec-next
> Applying: xfrm: add support for UDPv6 encapsulation of ESP
> Applying: xfrm: add IPv6 support for espintcp
> error: patch failed: net/xfrm/espintcp.c:416
> error: net/xfrm/espintcp.c: patch does not apply
> Patch failed at 0002 xfrm: add IPv6 support for espintcp
> 
> Can you please doublecheck this?

*facepalm*
I had the sk_destruct fix in my branch when I exported those
patches, so git format-patch exported a patch with slightly different
offsets.

Sorry for the mess, I'll post a v3 that applies correctly on ipsec-next.

-- 
Sabrina